wu-sheng commented on a change in pull request #95:
URL:
https://github.com/apache/skywalking-nginx-lua/pull/95#discussion_r809753061
##########
File path: lib/skywalking/tracer.lua
##########
@@ -28,9 +28,7 @@ local nginxComponentId = 6000
local Tracer = {}
-function Tracer:start(upstream_name, correlation)
- local log = ngx.log
- local WARN = ngx.WARN
+function Tracer:start(upstream_name, correlation, is_propagation)
Review comment:
Why stop the propogation I mean?
Peer could be updated once header is not set. Even it is set aftet
injection, it is the integration level bug breaking the trace.
So, what I am confused is the use case. When and how should we use this
parameter.
I assume you have some APISIX integration cases? Could you make it more
clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
