wu-sheng commented on a change in pull request #95:
URL: 
https://github.com/apache/skywalking-nginx-lua/pull/95#discussion_r812478687



##########
File path: README.md
##########
@@ -65,8 +65,9 @@ http {
                 -- Currently, we can not have the upstream real network address
                 ------------------------------------------------------
                 skywalking_tracer:start("upstream service")

Review comment:
       If `skywalking_tracer:inject(ngx.ctx.exitSpan)` always works, then it 
seems pointless to keep manual `upstream service`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to