wu-sheng commented on a change in pull request #95:
URL:
https://github.com/apache/skywalking-nginx-lua/pull/95#discussion_r809804226
##########
File path: lib/skywalking/tracer.lua
##########
@@ -28,9 +28,7 @@ local nginxComponentId = 6000
local Tracer = {}
-function Tracer:start(upstream_name, correlation)
- local log = ngx.log
- local WARN = ngx.WARN
+function Tracer:start(upstream_name, correlation, is_propagation)
Review comment:
Then you could do an injection later, and change the document about
where is the correct phase to inject.
Adding a parameter breaks the API already. If you want, start a tracer and
add another step called inject like other agents did. It is better than right
now. Propagation is a very official concept in tracing, `is_propagation=false`
means breaking context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
