wu-sheng commented on issue #3065: Propose a API change : AbstractTracerContext#asyncStop and AsyncSpan#asyncFinish return boolean URL: https://github.com/apache/skywalking/pull/3065#issuecomment-511065266 No matter Chinese or English, this API proposal is not right. Every tracing API have change to miss closing, but that the responsibilities of plugin. There is no need to do this check. You should know as plugin developer. If close is un clear, then should not use async, choose capture and continued.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
