wu-sheng commented on issue #3065: Propose a API change : AbstractTracerContext#asyncStop and AsyncSpan#asyncFinish return boolean URL: https://github.com/apache/skywalking/pull/3065#issuecomment-511080495 How to finish it is plugin responsibility. You could use dynamic field or anything you like to coordinate it. But basically, I don't know vertx, so I need you to make it clear why you can't be sure about when to close it, and why you try to finish it duplicatedly. I am just saying, your proposal doesn't change anything, because think in this way, if there is two async spans, what happens? Is this API change still helpful? I think it isn't, no one should check the context in this way. It is same when you called span#close twice, you close other plugin span.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
