wu-sheng commented on issue #3065: Propose a API change : AbstractTracerContext#asyncStop and AsyncSpan#asyncFinish return boolean URL: https://github.com/apache/skywalking/pull/3065#issuecomment-511087808 I am not following, your descriptions are not consistent. I don't understand how you want to do. But your proposal to return the count, the reason I am arguing, is we should not do that, it is a wrong design. For 1, The document tolds you very clear, prepareAsync first, then finish at somewhere else. What is your question? For 2, simple answer is no. I think you haven't understood what is async finish. Async finish is only for make span finished out of current tracing context, and keep tag and duration right.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
