wu-sheng commented on a change in pull request #3068: improve
ContextManager.stopSpan performance: call ThreadLocal only once
URL: https://github.com/apache/skywalking/pull/3068#discussion_r303226673
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java
##########
@@ -165,12 +166,20 @@ public static AbstractSpan activeSpan() {
return get().activeSpan();
}
+ /**
+ * Plese use `ContextManager.stopSpan(span)` if could, it's can "fail-fast"
Review comment:
Why call it `fail-fast`? From Wikipedia, this is the definition of it. At
here, you are just avoiding to get threadlocal twice. I think you should
re-write the comment.
> In systems design, a fail-fast system is one which immediately reports at
its interface any condition that is likely to indicate a failure. Fail-fast
systems are usually designed to stop normal operation rather than attempt to
continue a possibly flawed process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
