wu-sheng commented on a change in pull request #3068: improve
ContextManager.stopSpan performance: call ThreadLocal only once
URL: https://github.com/apache/skywalking/pull/3068#discussion_r303249730
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java
##########
@@ -165,12 +166,20 @@ public static AbstractSpan activeSpan() {
return get().activeSpan();
}
+ /**
+ * Plese use `ContextManager.stopSpan(span)` if could, it's can "fail-fast"
Review comment:
This thing, you are describing is already in codes, so it is not related to
this PR.
I could get your point, but you should know, many plugins can't choose this
way, even they want to.
Fail-fast is a concept widely definition, you should not define it,
especially for an English term.
If you want to add some comments or recommendation of using this, raise
other PR with more accurate words.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
