wu-sheng commented on a change in pull request #3068: improve
ContextManager.stopSpan performance: call ThreadLocal only once
URL: https://github.com/apache/skywalking/pull/3068#discussion_r303292472
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java
##########
@@ -165,12 +166,20 @@ public static AbstractSpan activeSpan() {
return get().activeSpan();
}
+ /**
+ * Plese use `ContextManager.stopSpan(span)` if could, it's can "fail-fast"
Review comment:
```suggestion
* Recommend use ContextManager::stopSpan(AbstractSpan span), because in
that way,
* the TracingContext core could verify this span is the active one, in
order to avoid stop unexpected span.
* If the current span is hard to get or only could get by
low-performance way, this stop way is still acceptable.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
