hanahmily commented on code in PR #135:
URL:
https://github.com/apache/skywalking-banyandb/pull/135#discussion_r904630777
##########
api/proto/banyandb/measure/v1/rpc.proto:
##########
@@ -25,9 +25,15 @@ package banyandb.measure.v1;
import "banyandb/measure/v1/query.proto";
import "banyandb/measure/v1/write.proto";
import "banyandb/measure/v1/topn.proto";
+import "google/api/annotations.proto";
service MeasureService {
- rpc Query(banyandb.measure.v1.QueryRequest) returns
(banyandb.measure.v1.QueryResponse);
+ rpc Query(banyandb.measure.v1.QueryRequest) returns
(banyandb.measure.v1.QueryResponse){
Review Comment:
You should set up `base_path` in this file
##########
api/proto/banyandb/stream/v1/rpc.proto:
##########
@@ -24,8 +24,14 @@ package banyandb.stream.v1;
import "banyandb/stream/v1/query.proto";
import "banyandb/stream/v1/write.proto";
+import "google/api/annotations.proto";
service StreamService {
Review Comment:
lack of `base_path`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
