hanahmily commented on code in PR #135:
URL:
https://github.com/apache/skywalking-banyandb/pull/135#discussion_r905672370
##########
api/proto/banyandb/database/v1/rpc.proto:
##########
@@ -64,11 +70,33 @@ message StreamRegistryServiceListResponse {
}
service StreamRegistryService {
- rpc Create(StreamRegistryServiceCreateRequest) returns
(StreamRegistryServiceCreateResponse);
- rpc Update(StreamRegistryServiceUpdateRequest) returns
(StreamRegistryServiceUpdateResponse);
- rpc Delete(StreamRegistryServiceDeleteRequest) returns
(StreamRegistryServiceDeleteResponse);
- rpc Get(StreamRegistryServiceGetRequest) returns
(StreamRegistryServiceGetResponse);
- rpc List(StreamRegistryServiceListRequest) returns
(StreamRegistryServiceListResponse);
+ rpc Create(StreamRegistryServiceCreateRequest) returns
(StreamRegistryServiceCreateResponse){
+ option(google.api.http) = {
+ post:"/v1/stream/schema"
+ body:"*"
+ };
+ };
+ rpc Update(StreamRegistryServiceUpdateRequest) returns
(StreamRegistryServiceUpdateResponse){
+ option(google.api.http) = {
+ put:"/v1/stream/schema"
+ body:"*"
+ };
+ };
+ rpc Delete(StreamRegistryServiceDeleteRequest) returns
(StreamRegistryServiceDeleteResponse){
+ option(google.api.http) = {
+ delete:"/v1/stream/schema/{metadata.group}/{metadata.name}"
+ };
+ };
+ rpc Get(StreamRegistryServiceGetRequest) returns
(StreamRegistryServiceGetResponse){
+ option(google.api.http) = {
+ get:"/v1/stream/schema/{metadata.group}/{metadata.name}"
+ };
+ };
+ rpc List(StreamRegistryServiceListRequest) returns
(StreamRegistryServiceListResponse){
+ option(google.api.http) = {
+ get:"/v1/stream/schema-group/{group}"
Review Comment:
we have to use `/v1/stream/schema/lists` instead here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
