lujiajing1126 commented on code in PR #135:
URL:
https://github.com/apache/skywalking-banyandb/pull/135#discussion_r905663273
##########
api/proto/banyandb/database/v1/rpc.proto:
##########
@@ -202,11 +230,33 @@ message MeasureRegistryServiceListResponse {
}
service MeasureRegistryService {
- rpc Create(MeasureRegistryServiceCreateRequest) returns
(MeasureRegistryServiceCreateResponse);
- rpc Update(MeasureRegistryServiceUpdateRequest) returns
(MeasureRegistryServiceUpdateResponse);
- rpc Delete(MeasureRegistryServiceDeleteRequest) returns
(MeasureRegistryServiceDeleteResponse);
- rpc Get(MeasureRegistryServiceGetRequest) returns
(MeasureRegistryServiceGetResponse);
- rpc List(MeasureRegistryServiceListRequest) returns
(MeasureRegistryServiceListResponse);
+ rpc Create(MeasureRegistryServiceCreateRequest) returns
(MeasureRegistryServiceCreateResponse){
Review Comment:
CRUD path seems strange. They do not fully follow Restful style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
