wu-sheng commented on code in PR #9622:
URL: https://github.com/apache/skywalking/pull/9622#discussion_r972964247


##########
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/AnalyzerModuleProvider.java:
##########
@@ -85,15 +90,19 @@ public ModuleConfig createConfigBeanIfAbsent() {
 
     @Override
     public void prepare() throws ServiceNotProvidedException, 
ModuleStartException {
-        thresholds = new 
DBLatencyThresholdsAndWatcher(moduleConfig.getSlowDBAccessThreshold(), this);
+        dbLatencyThresholdsAndWatcher = new 
DBLatencyThresholdsAndWatcher(moduleConfig.getSlowDBAccessThreshold(), this);
+        cacheReadLatencyThresholdsAndWatcher = new 
CacheReadLatencyThresholdsAndWatcher(moduleConfig.getSlowCacheReadThreshold(), 
this);
+        cacheWriteLatencyThresholdsAndWatcher = new 
CacheWriteLatencyThresholdsAndWatcher(moduleConfig.getSlowCacheWriteThreshold(),
 this);

Review Comment:
   Don't put new codes in the first lines. This doesn't have to be here. Please 
add after `traceSamplingPolicyWatcher`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to