wu-sheng commented on code in PR #9622: URL: https://github.com/apache/skywalking/pull/9622#discussion_r972970461
########## oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/vservice/VirtualCacheProcessor.java: ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.analyzer.provider.trace.parser.listener.vservice; + +import com.google.gson.Gson; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair; +import org.apache.skywalking.apm.network.language.agent.v3.SegmentObject; +import org.apache.skywalking.apm.network.language.agent.v3.SpanLayer; +import org.apache.skywalking.apm.network.language.agent.v3.SpanObject; +import org.apache.skywalking.oap.server.analyzer.provider.AnalyzerModuleConfig; +import org.apache.skywalking.oap.server.analyzer.provider.trace.parser.SpanTags; +import org.apache.skywalking.oap.server.core.analysis.IDManager; +import org.apache.skywalking.oap.server.core.analysis.Layer; +import org.apache.skywalking.oap.server.core.analysis.TimeBucket; +import org.apache.skywalking.oap.server.core.config.NamingControl; +import org.apache.skywalking.oap.server.core.source.ServiceMeta; +import org.apache.skywalking.oap.server.core.source.Source; +import org.apache.skywalking.oap.server.core.source.VirtualCacheRead; +import org.apache.skywalking.oap.server.core.source.VirtualCacheSlowRead; +import org.apache.skywalking.oap.server.core.source.VirtualCacheSlowWrite; +import org.apache.skywalking.oap.server.core.source.VirtualCacheWrite; +import org.apache.skywalking.oap.server.library.util.StringUtil; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.function.Consumer; +import java.util.stream.Collectors; + +@Slf4j +@RequiredArgsConstructor +public class VirtualCacheProcessor implements VirtualServiceProcessor { + + private final NamingControl namingControl; + + private final AnalyzerModuleConfig config; + + private final List<Source> sourceList = new ArrayList<>(); + + @Override + public void prepareVSIfNecessary(SpanObject span, SegmentObject segmentObject) { + if (span.getSpanLayer() != SpanLayer.Cache) { + return; + } + Map<String, String> tags = span.getTagsList().stream() Review Comment: I can get the idea why you created `VirtualServiceProcessor`. But there is a side effect, you make every processor implementations iterate span's tags by themselves. This is a performance impact. Because SkyWalking could process 100b segments, which means 1000-2000b spans per day. The increment of iteration could be a disaster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
