wu-sheng commented on code in PR #9622:
URL: https://github.com/apache/skywalking/pull/9622#discussion_r972986496
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java:
##########
@@ -106,6 +107,10 @@ public class DefaultScopeDefine {
public static final int ZIPKIN_SERVICE_SPAN = 52;
public static final int ZIPKIN_SERVICE_RELATION = 53;
public static final int PROCESS_RELATION = 54;
+ public static final int CACHE_READ_ACCESS = 55;
+ public static final int CACHE_WRITE_ACCESS = 56;
+ public static final int CACHE_SLOW_WRITE = 57;
+ public static final int CACHE_SLOW_READ = 58;
Review Comment:
These four should be merged into two. The source should include read/write
as an attribute rather than using two sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
