nisiyong opened a new pull request, #397:
URL: https://github.com/apache/skywalking-java/pull/397
<!--
⚠️ Please make sure to read this template first, pull requests that
don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g.
<framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Report agent version to OAP
Currently, the agent version used by all applications cannot be sensed, It
is beneficial for agent developers to diagnose some problems. I use
[git-commit-id-maven-plugin](https://github.com/git-commit-id/git-commit-id-maven-plugin)
to generate the agent version, and report it to OAP when the agent starts.
The agent version is consist of three parts:
1. **build version**: the maven project version
2. **short commit id**: git commit short id
3. **date**: build date.
Here is the agent log from my local env with this feature:
```
INFO 2022-11-24 09:51:32.331 main InstanceJsonPropertiesUtil : SkyWalking
agent version: 8.14.0-SNAPSHOT-add2bc4-221124
```
And the OAP server could show this agent version, too. What do you think of
this feature? Any suggestions? @wu-sheng
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES`
log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
