nisiyong commented on PR #397: URL: https://github.com/apache/skywalking-java/pull/397#issuecomment-1325990705
@wu-sheng @kezhenxu94 After reading [AgentIDDecorator.java](https://github.com/apache/skywalking-java/blob/70b3e88b0fc133d4e74dbe54ae945d01b860a735/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/AgentIDDecorator.java#L41-L42), I still think this PR implementation will be better. There are some reasons: 1. Who will care about the agent version? Obviously, the skywalking maintainer in each company. If they don't need to develop their own plugins, they could download the agent distribution which has the `skywalking-agent-git.properties`, why do they need to build from the source code tarball, rather than from the Github repo? If they do that, just let the version set `Unkown`, I think it is fine for them. 2. The `AgentIDDecorator` doesn't contain the git commit id which is important to help the maintainers identify all agent versions built from the related source code. Also, we don't need to report the agent version in each client request, I think what `AgentIDDecorator` implementation is more like the network protocol versions in each request. 3. Bind the version with instance heartbeat, it will be easy to maintain, if we upgrade the agent, after the application restarts, we could identify it has been upgraded quickly. Thank you all, if you have any suggestions, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
