kezhenxu94 commented on PR #397: URL: https://github.com/apache/skywalking-java/pull/397#issuecomment-1326027368
> 1. Who will care about the agent version? Obviously, the skywalking maintainer in each company. If they don't need to develop their own plugins, they could download the agent distribution which has the `skywalking-agent-git.properties`, why do they need to build from the source code tarball, rather than from the Github repo? If they do that, just let the version set `Unkown`, I think it is fine for them. There is no reason for us to doubt why they build from source code tarball, we as an Apache project are mandatory to provide source tarball and guarantee that users can use the project after compilation from that tarball. I'm totally fine to let the version be `Unknown` but please document this because this is stored in storage and (maybe) UI would display this someday, leaving the version to be `Unknown` should bring confusion to users and unnecessary bug report to the community unless clearly documented. > 2. The `AgentIDDecorator` doesn't contain the git commit id which is important to help the maintainers identify all agent versions built from the related source code. Also, we don't need to report the agent version in each client request, I think what `AgentIDDecorator` implementation is more like the network protocol versions in each request. `AgentIDDecorator` was indeed introduced as a network protocol version for, i.e. cloud vendors, looks like we cannot reuse this part, I'm ok to accept this PR once other comments are addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
