lujiajing1126 commented on code in PR #10128:
URL: https://github.com/apache/skywalking/pull/10128#discussion_r1045087481
##########
oap-server/server-starter/src/main/resources/application.yml:
##########
@@ -235,10 +235,9 @@ storage:
superDatasetShardsFactor:
${SW_STORAGE_BANYANDB_SUPERDATASET_SHARDS_FACTOR:2}
concurrentWriteThreads: ${SW_STORAGE_BANYANDB_CONCURRENT_WRITE_THREADS:15}
profileTaskQueryMaxSize:
${SW_STORAGE_BANYANDB_PROFILE_TASK_QUERY_MAX_SIZE:200} # the max number of
fetch task in a request
- streamBlockInterval: ${SW_STORAGE_BANYANDB_STREAM_BLOCK_INTERVAL:4} # Unit
is hour
- streamSegmentInterval: ${SW_STORAGE_BANYANDB_STREAM_SEGMENT_INTERVAL:24} #
Unit is hour
- measureBlockInterval: ${SW_STORAGE_BANYANDB_MEASURE_BLOCK_INTERVAL:4} #
Unit is hour
- measureSegmentInterval: ${SW_STORAGE_BANYANDB_MEASURE_SEGMENT_INTERVAL:24}
# Unit is hour
+ blockIntervalHours: ${SW_STORAGE_BANYANDB_BLOCK_INTERVAL_HOURS:24} # Unit
is hour
+ segmentIntervalDays: ${SW_STORAGE_BANYANDB_SEGMENT_INTERVAL_DAYS:1} # Unit
is day
+ overrideGroupIntervals: ${SW_STORAGE_BANYANDB_OVERRIDE_GROUP_INTERVALS:""}
# For example, group1,4,1;group2,2,2
Review Comment:
> What is `overrideGroupIntervals`?
Mentioned in issue https://github.com/apache/skywalking/issues/10102, we
have to Support setting the interval rule based on the group name more than
global defaults.
##########
oap-server/server-starter/src/main/resources/application.yml:
##########
@@ -235,10 +235,9 @@ storage:
superDatasetShardsFactor:
${SW_STORAGE_BANYANDB_SUPERDATASET_SHARDS_FACTOR:2}
concurrentWriteThreads: ${SW_STORAGE_BANYANDB_CONCURRENT_WRITE_THREADS:15}
profileTaskQueryMaxSize:
${SW_STORAGE_BANYANDB_PROFILE_TASK_QUERY_MAX_SIZE:200} # the max number of
fetch task in a request
- streamBlockInterval: ${SW_STORAGE_BANYANDB_STREAM_BLOCK_INTERVAL:4} # Unit
is hour
- streamSegmentInterval: ${SW_STORAGE_BANYANDB_STREAM_SEGMENT_INTERVAL:24} #
Unit is hour
- measureBlockInterval: ${SW_STORAGE_BANYANDB_MEASURE_BLOCK_INTERVAL:4} #
Unit is hour
- measureSegmentInterval: ${SW_STORAGE_BANYANDB_MEASURE_SEGMENT_INTERVAL:24}
# Unit is hour
+ blockIntervalHours: ${SW_STORAGE_BANYANDB_BLOCK_INTERVAL_HOURS:24} # Unit
is hour
+ segmentIntervalDays: ${SW_STORAGE_BANYANDB_SEGMENT_INTERVAL_DAYS:1} # Unit
is day
+ overrideGroupIntervals: ${SW_STORAGE_BANYANDB_OVERRIDE_GROUP_INTERVALS:""}
# For example, group1,4,1;group2,2,2
Review Comment:
> What is `overrideGroupIntervals`?
Mentioned in issue https://github.com/apache/skywalking/issues/10102, we
have to support setting the interval rule based on the group name more than
global defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
