lujiajing1126 commented on code in PR #10128:
URL: https://github.com/apache/skywalking/pull/10128#discussion_r1045087598
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBStorageConfig.java:
##########
@@ -57,31 +57,24 @@ public class BanyanDBStorageConfig extends ModuleConfig {
*/
private int superDatasetShardsFactor;
/**
- * block interval for Stream group.
- * Unit is hours.
+ * Default global block interval.
+ * Unit is hour.
*
- * @since 9.3.0
+ * @since 9.4.0
*/
- private int streamBlockInterval;
+ private int blockIntervalHours;
/**
- * segment interval for Stream group.
- * Unit is hours.
+ * Default global segment interval.
+ * Unit is day.
*
- * @since 9.3.0
+ * @since 9.4.0
*/
- private int streamSegmentInterval;
+ private int segmentIntervalDays;
/**
- * block interval for Measure group.
- * Unit is hours.
+ * Override the default global configurations.
+ * It works for all groups except `measure-default`.
Review Comment:
> What do you mean `override` default? Who set the default?
`blockIntervalHours` and `segmentIntervalDays` are now global interval rules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
