lujiajing1126 commented on code in PR #10128:
URL: https://github.com/apache/skywalking/pull/10128#discussion_r1045090087
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -60,9 +61,9 @@ public boolean isExists(Model model) throws StorageException {
// then check entity schema
if (metadata.findRemoteSchema(c).isPresent()) {
// register models only locally but not remotely
- if (model.isTimeSeries() && model.isRecord()) { // stream
+ if (model.isRecord()) { // stream
MetadataRegistry.INSTANCE.registerStreamModel(model,
config, configService);
- } else if (model.isTimeSeries() && !model.isRecord()) { //
measure
Review Comment:
We've already checked at the beginning of `isExists`,
```java
@Override
public boolean isExists(Model model) throws StorageException {
if (!model.isTimeSeries()) {
return true;
}
...
}
```
So I think we can safely ignore other conditions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
