wu-sheng commented on code in PR #448:
URL: https://github.com/apache/skywalking-java/pull/448#discussion_r1095776168
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/AgentClassLoader.java:
##########
@@ -44,25 +40,57 @@
/**
* The <code>AgentClassLoader</code> represents a classloader, which is in
charge of finding plugins and interceptors.
*/
-public class AgentClassLoader extends ClassLoader {
+public class AgentClassLoader extends URLClassLoader {
+ private static final ILog LOGGER;
+ /**
+ * Storage plug-in jar package url address
+ */
+ private static URL[] ARRAY_PLUGINS_URL;
Review Comment:
By reading this, I feel your PR should be separated into two parts.
1. Use URLClassLoader as the parent of `AgentClassLoader`. I know this could
be done, but don't do this as didn't see the necessity
2. Really add OSGI relative codes.
The reason I proposed this is, I want to the change log clear and review
easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
