2han9wen71an commented on code in PR #448:
URL: https://github.com/apache/skywalking-java/pull/448#discussion_r1096489957
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/AgentClassLoader.java:
##########
@@ -169,31 +135,15 @@ private Class<?> processLoadedClass(Class<?> loadedClass)
{
return loadedClass;
}
- private List<Jar> getAllJars() {
- if (allJars == null) {
- jarScanLock.lock();
- try {
- if (allJars == null) {
- allJars = doGetJars();
- }
- } finally {
- jarScanLock.unlock();
- }
- }
-
- return allJars;
- }
-
- private LinkedList<Jar> doGetJars() {
- LinkedList<Jar> jars = new LinkedList<>();
+ private static LinkedList<URL> doGetJars(List<File> classpath) {
Review Comment:
Because it needs to be called in a static method, and only need to
initialize the plugin list once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
