2han9wen71an commented on code in PR #448:
URL: https://github.com/apache/skywalking-java/pull/448#discussion_r1096491318
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/AgentClassLoader.java:
##########
@@ -72,89 +100,27 @@ public static AgentClassLoader getDefault() {
*
* @throws AgentPackageNotFoundException if agent package is not found.
*/
- public static void initDefaultLoader() throws
AgentPackageNotFoundException {
+ public static void initDefaultLoader() {
if (DEFAULT_LOADER == null) {
synchronized (AgentClassLoader.class) {
if (DEFAULT_LOADER == null) {
- DEFAULT_LOADER = new
AgentClassLoader(PluginBootstrap.class.getClassLoader());
+ DEFAULT_LOADER = new AgentClassLoader(PLUGIN_JAR_URLS,
PluginBootstrap.class.getClassLoader());
}
}
}
}
- public AgentClassLoader(ClassLoader parent) throws
AgentPackageNotFoundException {
- super(parent);
Review Comment:
Not so, because you override the `findClass` method, which only reads the
plugin directory and does not call parent `findClass`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
