wu-sheng commented on code in PR #561: URL: https://github.com/apache/skywalking-java/pull/561#discussion_r1240552284
########## test/plugin/scenarios/retransform-class-tomcat-scenario/configuration.yml: ########## @@ -17,7 +17,5 @@ type: tomcat entryService: http://localhost:8080/retransform-class-tomcat-scenario/case/retransform-class healthCheck: http://localhost:8080/retransform-class-tomcat-scenario/case/healthCheck -environment: - - CATALINA_OPTS="-Dskywalking.agent.is_cache_enhanced_class=true -Dskywalking.agent.class_cache_mode=FILE" dependencies: -withPlugins: apm-spring-annotation-plugin-*.jar +withPlugins: apm-*.jar Review Comment: The point is not about these two plugin tests, it is about the stability of the testing. The plugins are going to be added/removed from time to time, if you copy all, actually, you don't know which plugins exist, which may cause these tests to fail by other contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
