weixiang1862 commented on PR #11036: URL: https://github.com/apache/skywalking/pull/11036#issuecomment-1617815496
@wu-sheng @wankai123 It is not the final code, I want to confirm the following questions: 1. whether `reduce` is a good name? 2. `reduce` should be defined as function or aggregate function? 3. whether reduce avg agorithm should filter null values? 4. I use `(COMMA parameter)*` define aggregate function param list, It means aggregation function can have 0-N params, I'm worried it may effect other agg function，should I define it like 'function0' 'function1'? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
