wankai123 commented on PR #11036: URL: https://github.com/apache/skywalking/pull/11036#issuecomment-1618142521
> 1. whether `reduce` is a good name? aggregate_label or something? I think it's only for the `labeled_value` series. > 2. `reduce` should be defined as function or aggregate function? see https://github.com/apache/skywalking/pull/11036#discussion_r1250789220 > 3. whether reduce avg agorithm should filter null values? I think should reserve NULL if the result is NULL > 4. I use `(COMMA parameter)*` define aggregate function param list, It means aggregation function can have 0-N params, I'm worried it may effect other agg function，should I define it like 'function0' 'function1'? please refer to https://github.com/apache/skywalking/pull/11036#discussion_r1250789220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
