wankai123 commented on code in PR #11036:
URL: https://github.com/apache/skywalking/pull/11036#discussion_r1250789220
##########
oap-server/server-query-plugin/mqe-grammar/src/main/antlr4/org/apache/skywalking/mqe/rt/grammar/MQEParser.g4:
##########
@@ -27,7 +27,7 @@ expression
| expression mulDivMod expression # mulDivModOp
| expression addSub expression # addSubOp
| expression compare expression # compareOp
- | aggregation L_PAREN expression R_PAREN # aggregationOp
+ | aggregation L_PAREN expression (COMMA parameter)* R_PAREN # aggregationOp
Review Comment:
It's better to create a new expression like `top_n` or `relabels`. An
expression should have determined parameters to avoid unexpected parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
