mrproliu commented on code in PR #188:
URL: https://github.com/apache/skywalking-go/pull/188#discussion_r1675863048
##########
plugins/mux/serve_interceptor.go:
##########
@@ -63,7 +63,7 @@ func newWriterWrapper(rw interface{}) *writerWrapper {
writer := rw.(http.ResponseWriter)
hijacker, ok := rw.(http.Hijacker)
if !ok {
- log.Errorf("http.ResponseWriter does not implement
http.Hijacker")
+ log.Warnf("http.ResponseWriter does not implement
http.Hijacker")
Review Comment:
It's unnecessary because the Hijicker is not used for some frameworks. Users
will be confused about this log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
