mrproliu commented on code in PR #188:
URL: https://github.com/apache/skywalking-go/pull/188#discussion_r1675954908
##########
plugins/mux/serve_interceptor.go:
##########
@@ -68,3 +87,16 @@ func (w *writerWrapper) WriteHeader(statusCode int) {
w.statusCode = statusCode
w.ResponseWriter.WriteHeader(statusCode)
}
+
+func newWriterWrapperWithHijacker(writer http.ResponseWriter, hijacker
http.Hijacker) *writerWrapperWithHijacker {
+ return &writerWrapperWithHijacker{
+ w: newWriterWrapper(writer),
+ Hijacker: hijacker,
+ }
+}
+
+type writerWrapperWithHijacker struct {
+ w *writerWrapper
+ http.ResponseWriter
Review Comment:
The parent wrapper already contains this interface, please delete the
duplicate one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
