mrproliu commented on code in PR #188:
URL: https://github.com/apache/skywalking-go/pull/188#discussion_r1676570610
##########
test/plugins/scenarios/mux/config/excepted.yml:
##########
@@ -16,8 +16,42 @@
segmentItems:
- serviceName: mux
- segmentSize: ge 3
+ segmentSize: ge 4
segments:
+ - segmentId: not null
+ spans:
+ - operationName: GET:/ws
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: gt 0
+ endTime: gt 0
+ componentId: 5017
+ isError: false
+ spanType: Entry
+ peer: ''
+ skipAnalysis: false
+ tags:
+ - { key: http.method, value: GET }
+ - { key: url, value: 'localhost:8080/ws' }
+ - { key: status_code, value: '200' }
+ - segmentId: not null
+ spans:
+ - operationName: GET:/health
Review Comment:
Please delete the health checker.
##########
plugins/mux/serve_interceptor.go:
##########
@@ -68,3 +90,18 @@ func (w *writerWrapper) WriteHeader(statusCode int) {
w.statusCode = statusCode
w.ResponseWriter.WriteHeader(statusCode)
}
+
+func newWriterWrapperWithHijacker(writer http.ResponseWriter, hijacker
http.Hijacker) *writerWrapperWithHijacker {
+ wrapper := newWriterWrapper(writer)
+ return &writerWrapperWithHijacker{
+ ResponseWriter: wrapper,
+ writer: wrapper,
Review Comment:
Why there need to field to reference a same reference?
##########
test/plugins/scenarios/mux/main.go:
##########
@@ -54,12 +56,50 @@ func health(w http.ResponseWriter, r *http.Request) {
w.Write([]byte("success"))
}
+var upgrader = websocket.Upgrader{}
+
+func ws(w http.ResponseWriter, r *http.Request) {
+ c, err := upgrader.Upgrade(w, r, nil)
+ if err != nil {
+ log.Print("upgrade:", err)
+ return
+ }
+ defer c.Close()
+ for {
+ mt, message, err := c.ReadMessage()
+ if err != nil {
+ log.Println("read:", err)
+ break
+ }
+ log.Printf("recv: %s", message)
+ err = c.WriteMessage(mt, message)
+ if err != nil {
+ log.Println("write:", err)
+ break
+ }
+ }
+}
+
func main() {
r := mux.NewRouter()
r.Path("/health").HandlerFunc(health)
r.Path("/consumer").HandlerFunc(consumer)
r.PathPrefix("/provider").Path("/{var}").HandlerFunc(provider)
+ r.Path("/ws").HandlerFunc(ws)
+
+ go func() {
+ time.Sleep(3 * time.Second)
+ u := url.URL{Scheme: "ws", Host: "localhost:8080", Path: "/ws"}
+ log.Printf("connecting to %s", u.String())
+ c, _, err := websocket.DefaultDialer.Dial(u.String(), nil)
+ if err != nil {
+ log.Fatal("dial:", err)
+ }
+ defer c.Close()
+ c.WriteMessage(websocket.TextMessage, []byte("hello from mux
test"))
Review Comment:
Could you move this message to the provider handler? The provider handler is
the entrypoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
