lujiajing1126 commented on code in PR #139: URL: https://github.com/apache/skywalking-query-protocol/pull/139#discussion_r1803982321
########## async-profiler.graphqls: ########## @@ -0,0 +1,176 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a profiler task +input AsyncProfilerTaskCreationRequest { + # need to monitor service id + serviceId: ID! + # serviceInstanceIds to monitored under the special service. + serviceInstanceIds: [String!]! + # duration of this task (second) + duration: Int! + # when the segment starts to execute, how long must it take before the monitor can be enable Review Comment: ```suggestion # Events enabled for AsyncProfiler in this task ``` ########## async-profiler.graphqls: ########## @@ -0,0 +1,176 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a profiler task +input AsyncProfilerTaskCreationRequest { + # need to monitor service id + serviceId: ID! + # serviceInstanceIds to monitored under the special service. Review Comment: ```suggestion # serviceInstanceIds to be monitored under the given service. ``` ########## async-profiler.graphqls: ########## @@ -0,0 +1,176 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a profiler task +input AsyncProfilerTaskCreationRequest { + # need to monitor service id + serviceId: ID! + # serviceInstanceIds to monitored under the special service. + serviceInstanceIds: [String!]! + # duration of this task (second) + duration: Int! + # when the segment starts to execute, how long must it take before the monitor can be enable + events: [AsyncProfilerEventType!]! + # other async-profiler args example alloc=2k,lock=2s Review Comment: ```suggestion # other async-profiler exec options, e.g. alloc=2k,lock=2s ``` ########## async-profiler.graphqls: ########## @@ -0,0 +1,176 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a profiler task +input AsyncProfilerTaskCreationRequest { + # need to monitor service id Review Comment: ```suggestion # service id to be monitored ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
