zhengziyi0117 commented on code in PR #139:
URL:
https://github.com/apache/skywalking-query-protocol/pull/139#discussion_r1807282087
##########
async-profiler.graphqls:
##########
@@ -28,16 +28,27 @@ input AsyncProfilerTaskCreationRequest {
execArgs: String
}
-# profiler task create result
+# AsyncProfiler task create result
type AsyncProfilerTaskCreationResult {
- # if null or empty means the task create success, otherwise get create
error reason
- errorReason: String
+ # if null means the task create success, otherwise get create error reason
+ errorReason: AsyncProfilerTaskCreationErrorType
Review Comment:
> Let's provide an enum to list the error code(extend later). Then, message
could be about details.
Sorry, maybe I misunderstood this sentence. I thought we defined the
enumeration in graphql first, and then added errCode and errMsg when
implementing the code. And I want to know what you want to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
