zhengziyi0117 commented on code in PR #139:
URL:
https://github.com/apache/skywalking-query-protocol/pull/139#discussion_r1807295209
##########
async-profiler.graphqls:
##########
@@ -28,16 +28,27 @@ input AsyncProfilerTaskCreationRequest {
execArgs: String
}
-# profiler task create result
+# AsyncProfiler task create result
type AsyncProfilerTaskCreationResult {
- # if null or empty means the task create success, otherwise get create
error reason
- errorReason: String
+ # if null means the task create success, otherwise get create error reason
+ errorReason: AsyncProfilerTaskCreationErrorType
Review Comment:
Can I modify it like this?
```graphql
# AsyncProfiler task create result
type AsyncProfilerTaskCreationResult {
# if null or empty means the task create success, otherwise get create
error reason
# errorCode: 10000 -> ARGUMENT_ERROR include
errorReason(SERVICE_ID_IS_NULL,DURATION_IS_NEGATIVE,EVENT_IS_EMPTY)
# errorCode: 10001 -> ALREADY_MONITOR include
errorReason(ALREADY_PROFILING)
errorReason: String
errorCode: Int
# get task id when create success
id: String
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
