lujiajing1126 commented on code in PR #139: URL: https://github.com/apache/skywalking-query-protocol/pull/139#discussion_r1808015946
########## async-profiler.graphqls: ########## @@ -0,0 +1,188 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a async-profiler task +input AsyncProfilerTaskCreationRequest { + # Define the service to execute the task + serviceId: ID! + # Define which instances need to execute tasks + serviceInstanceIds: [String!]! + # Define the duration of this task (second) + duration: Int! + # Define which event types this task needs to collect. You can choose cpu and alloc... + events: [AsyncProfilerEventType!]! + # other async-profiler execute options, e.g. alloc=2k,lock=2s + execArgs: String +} + +# AsyncProfiler task creation result +type AsyncProfilerTaskCreationResult { + # Code represents success or failure. If successful, it returns the task id, otherwise it returns the error reason + code: AsyncProfilerTaskCreationType! + # ErrorCode means if code indicates an error, then the detailed reason for the exception is returned. + errorReason: String + # Task id + id: String +} + +# AsyncProfiler task creation type +enum AsyncProfilerTaskCreationType { + # Task created successfully + SUCCESS + # Task creation failed due to argument errors + ARGUMENT_ERROR + # The current service already has a async-profiler task executing + ALREADY_PROFILING_ERROR +} + +# Request to query async-profiler task list +input AsyncProfilerTaskListRequest { + # Define the task list under which service is obtained + serviceId: ID! + # Start time + startTime: Long + # End time + endTime: Long + # The most recent limit number of tasks + limit: Int +} + +# Request to query flame graph analyzation +input AsyncProfilerAnalyzationRequest { + # Define which task to analyze + taskId: ID! + # Define which service instances generate data for analysis Review Comment: ```suggestion # instanceIds defines the instances to be included for analysis. ``` ########## async-profiler.graphqls: ########## @@ -0,0 +1,188 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a async-profiler task +input AsyncProfilerTaskCreationRequest { + # Define the service to execute the task + serviceId: ID! + # Define which instances need to execute tasks + serviceInstanceIds: [String!]! + # Define the duration of this task (second) + duration: Int! + # Define which event types this task needs to collect. You can choose cpu and alloc... + events: [AsyncProfilerEventType!]! + # other async-profiler execute options, e.g. alloc=2k,lock=2s + execArgs: String +} + +# AsyncProfiler task creation result +type AsyncProfilerTaskCreationResult { + # Code represents success or failure. If successful, it returns the task id, otherwise it returns the error reason + code: AsyncProfilerTaskCreationType! + # ErrorCode means if code indicates an error, then the detailed reason for the exception is returned. + errorReason: String + # Task id + id: String +} + +# AsyncProfiler task creation type +enum AsyncProfilerTaskCreationType { + # Task created successfully + SUCCESS + # Task creation failed due to argument errors + ARGUMENT_ERROR + # The current service already has a async-profiler task executing + ALREADY_PROFILING_ERROR +} + +# Request to query async-profiler task list +input AsyncProfilerTaskListRequest { + # Define the task list under which service is obtained + serviceId: ID! + # Start time + startTime: Long + # End time + endTime: Long + # The most recent limit number of tasks Review Comment: ```suggestion # limit defines the number of the tasks to be returned. ``` ########## async-profiler.graphqls: ########## @@ -0,0 +1,188 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a async-profiler task +input AsyncProfilerTaskCreationRequest { + # Define the service to execute the task + serviceId: ID! + # Define which instances need to execute tasks + serviceInstanceIds: [String!]! + # Define the duration of this task (second) + duration: Int! + # Define which event types this task needs to collect. You can choose cpu and alloc... + events: [AsyncProfilerEventType!]! + # other async-profiler execute options, e.g. alloc=2k,lock=2s + execArgs: String +} + +# AsyncProfiler task creation result +type AsyncProfilerTaskCreationResult { + # Code represents success or failure. If successful, it returns the task id, otherwise it returns the error reason + code: AsyncProfilerTaskCreationType! + # ErrorCode means if code indicates an error, then the detailed reason for the exception is returned. + errorReason: String + # Task id + id: String +} + +# AsyncProfiler task creation type +enum AsyncProfilerTaskCreationType { + # Task created successfully + SUCCESS + # Task creation failed due to argument errors + ARGUMENT_ERROR + # The current service already has a async-profiler task executing + ALREADY_PROFILING_ERROR +} + +# Request to query async-profiler task list +input AsyncProfilerTaskListRequest { + # Define the task list under which service is obtained Review Comment: ```suggestion # serviceId associated with the task ``` ########## async-profiler.graphqls: ########## @@ -0,0 +1,188 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Request to create a async-profiler task +input AsyncProfilerTaskCreationRequest { + # Define the service to execute the task + serviceId: ID! + # Define which instances need to execute tasks + serviceInstanceIds: [String!]! + # Define the duration of this task (second) + duration: Int! + # Define which event types this task needs to collect. You can choose cpu and alloc... + events: [AsyncProfilerEventType!]! + # other async-profiler execute options, e.g. alloc=2k,lock=2s + execArgs: String +} + +# AsyncProfiler task creation result +type AsyncProfilerTaskCreationResult { + # Code represents success or failure. If successful, it returns the task id, otherwise it returns the error reason + code: AsyncProfilerTaskCreationType! + # ErrorCode means if code indicates an error, then the detailed reason for the exception is returned. + errorReason: String + # Task id + id: String +} + +# AsyncProfiler task creation type +enum AsyncProfilerTaskCreationType { + # Task created successfully + SUCCESS + # Task creation failed due to argument errors + ARGUMENT_ERROR + # The current service already has a async-profiler task executing + ALREADY_PROFILING_ERROR +} + +# Request to query async-profiler task list +input AsyncProfilerTaskListRequest { + # Define the task list under which service is obtained + serviceId: ID! + # Start time + startTime: Long + # End time + endTime: Long + # The most recent limit number of tasks + limit: Int +} + +# Request to query flame graph analyzation +input AsyncProfilerAnalyzationRequest { + # Define which task to analyze + taskId: ID! + # Define which service instances generate data for analysis + instanceIds: [String!]! + # JFR event type Review Comment: ```suggestion # eventType is the specific JFR Event type to be selected for analysis even if multiple events are included in the JFR file. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
