wu-sheng commented on code in PR #12671:
URL: https://github.com/apache/skywalking/pull/12671#discussion_r1823625472
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java:
##########
@@ -113,4 +121,29 @@ private void updateProfileTask(ModuleDefineHolder
moduleDefineHolder) {
log.warn("Unable to update profile task cache", e);
}
}
+
+ private void updateAsyncProfilerTask(ModuleDefineHolder
moduleDefineHolder) {
+ AsyncProfilerTaskCache taskCache =
moduleDefineHolder.find(CoreModule.NAME)
+ .provider()
+ .getService(AsyncProfilerTaskCache.class);
+ IAsyncProfilerTaskQueryDAO taskQueryDAO =
moduleDefineHolder.find(StorageModule.NAME)
Review Comment:
Service could be kept as a field rather than loading every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
