kezhenxu94 commented on code in PR #12671:
URL: https://github.com/apache/skywalking/pull/12671#discussion_r1823700825
##########
LICENSE:
##########
@@ -225,3 +225,4 @@ The text of each license is the standard Apache 2.0 license.
mvnw files from https://github.com/apache/maven-wrapper Apache 2.0
svg files from skywalking-ui/src/assets/icons:
https://github.com/google/material-design-icons Apache 2.0
ZipkinQueryHandler.java reference from
zipkin2.server.internal.ZipkinQueryApiV2: https://github.com/openzipkin/zipkin
Apache 2.0
+ async-profiler parser files in
server-library/library-async-profiler-jfr-parser from
https://github.com/open-telemetry/opentelemetry-proto/tree/v0.7.0 Apache 2.0
Review Comment:
Can’t we just use their Java SDK instead of copying everything over here?
https://mvnrepository.com/artifact/tools.profiler/async-profiler/3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
