kezhenxu94 commented on code in PR #12671:
URL: https://github.com/apache/skywalking/pull/12671#discussion_r1823722484
##########
LICENSE:
##########
@@ -225,3 +225,4 @@ The text of each license is the standard Apache 2.0 license.
mvnw files from https://github.com/apache/maven-wrapper Apache 2.0
svg files from skywalking-ui/src/assets/icons:
https://github.com/google/material-design-icons Apache 2.0
ZipkinQueryHandler.java reference from
zipkin2.server.internal.ZipkinQueryApiV2: https://github.com/openzipkin/zipkin
Apache 2.0
+ async-profiler parser files in
server-library/library-async-profiler-jfr-parser from
https://github.com/open-telemetry/opentelemetry-proto/tree/v0.7.0 Apache 2.0
Review Comment:
Take a look at https://github.com/jvm-profiling-tools/ap-loader it was
[mentioned by the author of
async-profiler](https://github.com/async-profiler/async-profiler/issues/93#issuecomment-1328155966)
and it fixes the issue you mentioned, every class has a package name in it
```shell
tar -tf /Users/kezhenxu94/Downloads/ap-loader-all-3.0-9.jar | grep .class |
pbcopy
one/proto/Proto.class
one/converter/jfr2pprof$Method.class
one/converter/jfr2nflx$1.class
one/converter/jfr2pprof.class
one/converter/Classifier.class
one/converter/Arguments.class
one/converter/FlameGraph$Frame.class
one/converter/CollapsedStacks.class
one/converter/jfr2flame.class
one/converter/FlameGraph.class
one/converter/jfr2nflx.class
one/converter/Main.class
one/converter/jfr2pprof$Location.class
one/converter/jfr2flame$1.class
one/jfr/JfrField.class
one/jfr/MethodRef.class
one/jfr/StackTrace.class
one/jfr/JfrReader.class
one/jfr/Element.class
one/jfr/Dictionary$Visitor.class
one/jfr/ClassRef.class
one/jfr/Dictionary.class
one/jfr/JfrClass.class
one/jfr/event/GCHeapSummary.class
one/jfr/event/ObjectCount.class
one/jfr/event/Event.class
one/jfr/event/ContendedLock.class
one/jfr/event/EventAggregator.class
one/jfr/event/EventAggregator$Visitor.class
one/jfr/event/ExecutionSample.class
one/jfr/event/LiveObject.class
one/jfr/event/AllocationSample.class
one/jfr/event/CPULoad.class
one/profiler/AsyncProfilerLoader$ExecutionResult.class
one/profiler/AsyncProfilerLoader.class
one/profiler/AsyncProfiler.class
one/profiler/AsyncProfilerLoader$OSNotSupportedException.class
one/profiler/Events.class
one/profiler/Counter.class
one/profiler/AsyncProfilerMXBean.class
one/profiler/AsyncProfilerLoader$1.class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
