wu-sheng commented on code in PR #12777:
URL: https://github.com/apache/skywalking/pull/12777#discussion_r1845969157
##########
oap-server/server-library/library-async-profiler-jfr-parser/pom.xml:
##########
@@ -30,4 +30,25 @@
<artifactId>library-async-profiler-jfr-parser</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>tools.profiler</groupId>
+ <artifactId>async-profiler-converter</artifactId>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <configuration>
+ <excludes>
+
**\/JFRConverter.java,**\/Frame.java,**\/Arguments.java,**\/Index.java,**\/Classifier.java,**\/CallStack.java
Review Comment:
I think we should keep the package name included as well. Also, we should
keep one class per line in the pom file to improve readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
