zhengziyi0117 commented on code in PR #12777:
URL: https://github.com/apache/skywalking/pull/12777#discussion_r1845992073
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/AsyncProfilerTaskLog.java:
##########
@@ -31,8 +31,8 @@
@AllArgsConstructor
@Builder
public class AsyncProfilerTaskLog {
+ // task id
private String id;
Review Comment:
Yes, this is a semantic bug I discovered recently. Originally, graphql
`queryAsyncProfilerTaskProgress` interface returned the `id` of log instead of
`taskId`, but it is defined as `taskId` in graphql comment. Here, it is
modified to taskId to conform to the semantics of graphql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
