zhengziyi0117 commented on code in PR #12777:
URL: https://github.com/apache/skywalking/pull/12777#discussion_r1846047861
##########
oap-server/server-library/library-async-profiler-jfr-parser/pom.xml:
##########
@@ -44,8 +44,16 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<excludes>
-
**\/JFRConverter.java,**\/Frame.java,**\/Arguments.java,**\/Index.java,**\/Classifier.java,**\/CallStack.java
+ **\/JFRConverter.java,
Review Comment:
Because `<includes>
org\/apache\/skywalking\/oap\/server\/library\/jfr\/**\/*.java
</includes>` is added below, excludes `one.jfr.*` is not
actually needed here.
Of course if you need, I can remove the `includes` and add `excludes
one.jfr.*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
