wu-sheng commented on code in PR #12884:
URL: https://github.com/apache/skywalking/pull/12884#discussion_r1893519042
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java:
##########
@@ -64,6 +64,10 @@ public void
bootedNow(List<ApplicationConfiguration.ModuleConfiguration> configu
}
public void rebalancedCluster(long rebalancedTime) {
+ if (!bootingStatus.isBooted()) {
+ return;
+ }
Review Comment:
I think we should wait here rather than `return`? If we skip this step, then
rebalancedTime and the telemetry metric of `cluster_rebalanced_time` are not
being updated. Worse, ServerStatusWatcher implementations would not get any
notification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
