wu-sheng commented on code in PR #12884:
URL: https://github.com/apache/skywalking/pull/12884#discussion_r1893535536
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java:
##########
@@ -64,6 +64,10 @@ public void
bootedNow(List<ApplicationConfiguration.ModuleConfiguration> configu
}
public void rebalancedCluster(long rebalancedTime) {
+ if (!bootingStatus.isBooted()) {
+ return;
+ }
Review Comment:
OK, thanks for the explanation. Then you need to move
`bootingStatus.setBooted(true);` to the last line of the `bootedNow` method.
Otherwise, the race condition could still happen, right?
> I think notice once is enough in bootstrap stage. If you concern about
cluster_rebalanced_time telemetry metric, how about move this return judge
after cluster_rebalanced_time creating?
That is not correct. Because actually, we don't do rebalancing
notifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
