weixiang1862 commented on code in PR #12884:
URL: https://github.com/apache/skywalking/pull/12884#discussion_r1893532228
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java:
##########
@@ -64,6 +64,10 @@ public void
bootedNow(List<ApplicationConfiguration.ModuleConfiguration> configu
}
public void rebalancedCluster(long rebalancedTime) {
+ if (!bootingStatus.isBooted()) {
+ return;
+ }
Review Comment:
ServerStatusWatcher will be notified by the method
`ServerStatusService#bootNow` right after bootstrap complete.
I think notice once is enough in bootstrap stage. If you concern about
`cluster_rebalanced_time` telemetry metric, how about move this return judge
after `cluster_rebalanced_time` creating?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
