wu-sheng commented on issue #4236: Optimize the elasticsearch-based query interface provided to UI URL: https://github.com/apache/skywalking/pull/4236#issuecomment-574966988 I know the codes are different. My point is, logically, they are doing very similar things. Again, I am not saying your codes are wrong, I just hope you could keep the changes as less as possible, and as clear as possible. Now, your codes include a lot of changes, mixed with existing logic. Some of these changes are not necessary for the way today. Maybe this makes you feel frustrating, but I have to set these requirements, as I also set the same requirements at #4220 review. All codes we accepted are the legacy of all contributors and users. We must keep them friendly to ready. Think in this way, you could simply change codes to finish what you want because all former contributors accepted these requirements.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
