Liu-XinYuan commented on a change in pull request #4236: Optimize the
elasticsearch-based query interface provided to UI
URL: https://github.com/apache/skywalking/pull/4236#discussion_r367754149
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/DurationUtils.java
##########
@@ -216,4 +216,59 @@ private DateTime parseToDateTime(Downsampling
downsampling, long time) throws Pa
return dateTime;
}
+
+ public long convertBucketTotIimestamp(boolean isStart, long bucket) throws
ParseException {
Review comment:
I know that to optimize the elasticsearch query, you should put the code on
the elasticsearch implementation class. @dmsolr will use the same conversion
logic as me, why can't I put it into DurationUtils so that he can reuse this
logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
