Liu-XinYuan commented on issue #4236: Optimize the elasticsearch-based query interface provided to UI URL: https://github.com/apache/skywalking/pull/4236#issuecomment-575009867 Structurally, I certainly hope that the logic of time conversion is put into the ElasticSearchClient class, so that the change area is small. And I want to put the time conversion logic into DurationUtils in order to keep the same logic. In this case, the ElasticSearchClient class will depend on the DurationUtils class, causing a circular dependency. This caused each class in the server-storage-plugin to be added with the time conversion logic. But for the time being, I can put the time conversion logic into ElasticSearchClient without relying on DurationUtils. I will try
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
