wu-sheng commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r479399444
##########
File path: pom.xml
##########
@@ -581,6 +588,7 @@
</resourceExcludes>
<excludes>
**/target/generated-test-sources/**,
+
org/apache/skywalking/apm/agent/core/logging/core/generated/LoggingBenchmark*.java,
Review comment:
> LinkedArrayBenchmark doesn' generate codes, as you can see from the
excludes list, nothing about DataCarrier packages.
Could you check why this? Even now, it doesn't generate new codes. I prefer
we don't need to generate anything.
Less dependency(even test scope only), less maintenance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
