wu-sheng commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r479623325
##########
File path: pom.xml
##########
@@ -581,6 +588,7 @@
</resourceExcludes>
<excludes>
**/target/generated-test-sources/**,
+
org/apache/skywalking/apm/agent/core/logging/core/generated/LoggingBenchmark*.java,
Review comment:
> I am still curious why you can run it seamlessly?
I am not sure either. The dependency seems not an issue. I am just checking
the inconsistent issue, two benchmarks having different exclusion configuration
concerns me.
> As I understand, this LOC should help
Then why your benchmark isn't excluded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
