wu-sheng commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r479621428
##########
File path: apm-sniffer/apm-agent-core/pom.xml
##########
@@ -104,6 +104,12 @@
<version>${ststem-rules.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
+ <version>${jmh.version}</version>
Review comment:
This is not required, right? As you have used the dependency management.
##########
File path: apm-sniffer/apm-agent-core/pom.xml
##########
@@ -104,6 +104,12 @@
<version>${ststem-rules.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
+ <version>${jmh.version}</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
You are adding this for agent core only, so the datacarrier benchmark is
still not runnable. I don't think this is the right way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
